-
Notifications
You must be signed in to change notification settings - Fork 70
refactor buffer storage 2a #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 12-17-refactor_buffer_storage
Are you sure you want to change the base?
refactor buffer storage 2a #177
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| } | ||
|
|
||
| attach_renderer(key: string, renderer: Renderer) { | ||
| console.log("ATTACHING RENDERER") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This console.log statement appears to be a debugging artifact and should be removed before merging to production.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
18fd8c0 to
98af6ed
Compare
3e1b193 to
0833ce7
Compare
98af6ed to
19505f0
Compare
0833ce7 to
89a8717
Compare
19505f0 to
9475c8a
Compare
89a8717 to
0ae3757
Compare
9475c8a to
2365605
Compare
0ae3757 to
61aaf34
Compare
2365605 to
4c76c23
Compare
61aaf34 to
f5d0d3a
Compare

Important
Refactor
src/interaction.tsto use specificd3types, add TypeScript error comments, and log renderer attachment.src/interaction.tsto use more specific types fromd3-selection,d3-timer, andd3-zoom.d3.SelectionwithSelection,d3.ContainerElementwithContainerElement,d3.TimerwithTimer,d3.ZoomBehaviorwithZoomBehavior, andd3.ZoomTransformwithZoomTransform.@ts-expect-errorcomments inzoom_to()andzoom_to_bbox()methods to handle TypeScript errors.attach_renderer()method to log when a renderer is attached.This description was created by
for 3e1b193. It will automatically update as commits are pushed.